Update review.yml

This commit is contained in:
PierreGode 2024-12-10 15:58:56 +01:00 committed by GitHub
parent 7a6ee82a1a
commit ca7b45bc57
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1,4 +1,5 @@
name: Code Review Pipeline name: Code Review Pipeline
on: on:
pull_request: pull_request:
types: [opened, synchronize, reopened] types: [opened, synchronize, reopened]
@ -30,101 +31,99 @@ jobs:
import requests import requests
import json import json
# Helper function to extract valid line numbers # Helper function to extract line numbers
def extract_line_number(line_info): def extract_line_number(issue_text):
try: try:
return int(line_info.split(" ")[1]) # Extract integer after "Line" if "Line" in issue_text:
except (IndexError, ValueError): line_part = issue_text.split("Line")[1].split(":")[0].strip()
return None # Return None if conversion fails return int(line_part)
except (ValueError, IndexError):
pass
return None
# Gather GitHub event details # Load GitHub event data
event_path = os.environ.get('GITHUB_EVENT_PATH') event_path = os.getenv("GITHUB_EVENT_PATH")
with open(event_path, 'r') as f: with open(event_path, 'r') as f:
event = json.load(f) event = json.load(f)
# Extract PR and repo details pr_number = event["pull_request"]["number"]
pr_number = event['pull_request']['number'] repo_full_name = event["repository"]["full_name"]
repo_full_name = event['repository']['full_name']
token = os.environ.get('GITHUB_TOKEN')
openai_key = os.environ.get('OPENAI_API_KEY')
# Get PR diff # Fetch PR diff
headers = { headers = {
'Authorization': f'token {token}', "Authorization": f'token {os.getenv("GITHUB_TOKEN")}',
'Accept': 'application/vnd.github.v3.diff', "Accept": "application/vnd.github.v3.diff",
} }
diff_url = event['pull_request']['url'] + "/files" diff_url = event["pull_request"]["url"] + "/files"
pr_files = requests.get(diff_url, headers=headers).json() pr_files = requests.get(diff_url, headers=headers).json()
inline_comments = [] # Collect inline comments to post # Prepare inline comments
inline_comments = []
# Loop through the files in the PR for file in pr_files:
for fdata in pr_files: filename = file["filename"]
filename = fdata['filename'] patch = file.get("patch", "")
patch = fdata.get('patch', '')
# Debug: Log the patch content to ensure it's being sent correctly if not patch.strip():
print(f"Reviewing file: {filename}") continue
print(f"Patch:\n{patch}")
# Call OpenAI for inline code analysis # Send patch to OpenAI for review
issues_prompt = f""" prompt = f"""
You are a code reviewer. Analyze the following code patch for issues such as: Analyze the following code patch and find:
- Syntax errors - Syntax errors
- Logical errors - Logical issues
- Best practices - Security vulnerabilities
Provide specific inline comments that include: For each issue, specify:
- The exact line number - Line number
- A clear explanation of the issue - Problem description
- A suggested fix - Suggested fix
Analyze only the provided code:
Patch:
{patch} {patch}
""" """
ai_headers = {"Content-Type": "application/json", "Authorization": f"Bearer {openai_key}"} openai_headers = {
data_issues = { "Authorization": f'Bearer {os.getenv("OPENAI_API_KEY")}',
"model": "gpt-4o-mini", "Content-Type": "application/json",
"messages": [{"role": "user", "content": issues_prompt}],
"temperature": 0.5
} }
issues_response = requests.post("https://api.openai.com/v1/chat/completions", headers=ai_headers, json=data_issues) openai_payload = {
issues_response.raise_for_status() "model": "gpt-4o-mini",
issues = issues_response.json()['choices'][0]['message']['content'].strip() "messages": [{"role": "user", "content": prompt}],
"temperature": 0.3,
}
response = requests.post(
"https://api.openai.com/v1/chat/completions",
headers=openai_headers,
json=openai_payload,
)
response.raise_for_status()
ai_output = response.json()["choices"][0]["message"]["content"]
# Debug: Log the AI's response # Process AI output
print(f"AI Response:\n{issues}") for issue in ai_output.split("\n"):
# Parse issues for inline comments
if issues and "no issues found" not in issues.lower():
for issue in issues.split("\\n- "):
if issue.strip():
# Example issue format: "Line X: Description of issue"
if "Line" in issue: if "Line" in issue:
parts = issue.split(":") line_number = extract_line_number(issue)
line_info = parts[0].strip() if line_number:
description = ":".join(parts[1:]).strip() description = issue.split(": ", 1)[-1].strip()
inline_comments.append(
# Extract valid line number {
line_number = extract_line_number(line_info)
if line_number is not None:
inline_comments.append({
"path": filename, "path": filename,
"line": line_number, "line": line_number,
"side": "RIGHT", # Changes are always on the "RIGHT" side in the diff "side": "RIGHT",
"body": f"**AI Code Review:**\n{description}" "body": f"**AI Code Review:**\n{description}",
})
# Post inline comments as a single review
if inline_comments:
review_data = {
"body": "AI-generated review comments for code issues.",
"event": "COMMENT",
"comments": inline_comments
} }
review_response = requests.post(f"https://api.github.com/repos/{repo_full_name}/pulls/{pr_number}/reviews", )
headers={'Authorization': f'token {token}', 'Accept': 'application/vnd.github.v3+json'},
json=review_data) # Submit review comments
if inline_comments:
review_url = f"https://api.github.com/repos/{repo_full_name}/pulls/{pr_number}/reviews"
review_data = {
"event": "COMMENT",
"body": "AI-generated inline comments for code review.",
"comments": inline_comments,
}
review_response = requests.post(review_url, headers=headers, json=review_data)
review_response.raise_for_status() review_response.raise_for_status()
print("Inline review comments posted successfully.") print("Code review comments posted successfully.")
else: else:
print("No issues found in the code.") print("No issues found in the code.")
EOF EOF